-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adds tokens to ImageGallery
#143
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-26bd042--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 26bd042
|
src/components/ui/ImageGallery/image-gallery-selector.module.scss
Outdated
Show resolved
Hide resolved
src/components/ui/ImageGallery/image-gallery-selector.module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just left some comments, nice job ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! 👏
What's the purpose of this pull request?
This PR applies the new vtex-sites/base.store#407 to
ImageGallery
: new scoped tokens linked to global ones.How does it work?
This PR uses local variables to parameterize the
ImageGallery
properties, then connects these scoped tokens to the global ones.How to test it?
ImageGallery
component and its related components should look just as it was before these changes. Preview LinkChecklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation