Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adds tokens to ImageGallery #143

Merged
merged 24 commits into from
Jun 27, 2022
Merged

Conversation

hellofanny
Copy link
Contributor

@hellofanny hellofanny commented Jun 23, 2022

What's the purpose of this pull request?

This PR applies the new vtex-sites/base.store#407 to ImageGallery: new scoped tokens linked to global ones.

image

How does it work?

This PR uses local variables to parameterize the ImageGallery properties, then connects these scoped tokens to the global ones.

How to test it?

  • The ImageGallery component and its related components should look just as it was before these changes. Preview Link
  • You can check the story on Storybook Preview.

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 27, 2022 at 9:04PM (UTC)

@hellofanny hellofanny self-assigned this Jun 23, 2022
@vercel vercel bot temporarily deployed to preview June 23, 2022 01:53 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 23, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-26bd042--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 26bd042

@vercel vercel bot temporarily deployed to preview June 23, 2022 02:36 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 22:18 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 22:24 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2022 23:00 Inactive
@hellofanny hellofanny added the Chore General tasks. label Jun 23, 2022
@vercel vercel bot temporarily deployed to preview June 24, 2022 00:50 Inactive
@hellofanny hellofanny marked this pull request as ready for review June 27, 2022 15:39
@vtex-sites
Copy link

vtex-sites bot commented Jun 27, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 26bd042

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

Copy link
Contributor

@lucasfp13 lucasfp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just left some comments, nice job ✨

Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👏

@vercel vercel bot temporarily deployed to preview June 27, 2022 20:58 Inactive
@vercel vercel bot temporarily deployed to preview June 27, 2022 21:04 Inactive
@hellofanny hellofanny merged commit 26bd042 into main Jun 27, 2022
@hellofanny hellofanny deleted the theming-image-gallery-FSSS-282 branch June 27, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore General tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants