feat: Adds new tokens to Tiles
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-b9ab9da--nextjs.preview.vtex.app |
lucasfp13
force-pushed
the
feat/FSSS-266-adds-new-tokens-to-tiles
branch
from
de13213 to
ceff644
Compare
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit b9ab9da
|
filipewl
reviewed
Jun 23, 2022
There was a problem hiding this comment.
Looks good to me overall!
👏
Left some minor comments and suggestions for us to discuss further.
lucasfp13
force-pushed
the
feat/FSSS-266-adds-new-tokens-to-tiles
branch
from
e86de80 to
1e30433
Compare
hellofanny
reviewed
Jun 23, 2022
hellofanny
reviewed
Jun 23, 2022
hellofanny
reviewed
Jun 23, 2022
hellofanny
reviewed
Jun 23, 2022
hellofanny
reviewed
Jun 23, 2022
hellofanny
approved these changes
Jun 23, 2022
6 tasks
lucasfp13
force-pushed
the
feat/FSSS-266-adds-new-tokens-to-tiles
branch
from
20ec53c to
09cdda9
Compare
lucasfp13
force-pushed
the
feat/FSSS-266-adds-new-tokens-to-tiles
branch
from
4d14cb7 to
955e4cf
Compare
Story improvements
lucasfp13
force-pushed
the
feat/FSSS-266-adds-new-tokens-to-tiles
branch
from
bab163c to
4a53b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR applies the new Theming structure to
Tiles: new scoped tokens linked to global ones.How does it work?
This PR uses local variables to parameterize the
Tilesproperties, then connects these scoped tokens to the global ones.New global tokens:
None.
New local tokens for
Tiles:Default properties:
--fs-tiles-gap-mobilevar(--fs-grid-gap-2)--fs-tiles-gap-tabletvar(--fs-grid-gap-3)Tile
--fs-tiles-tile-min-width9rem--fs-tiles-tile-height24rem--fs-tiles-tile-height-desktop28rem--fs-tiles-tile-border-radiusvar(--fs-border-radius)How to test it?
The component should look just as it was before these changes.
Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.Documentation