Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: storybook improvements #129

Merged
merged 16 commits into from
Jun 17, 2022
Merged

Chore: storybook improvements #129

merged 16 commits into from
Jun 17, 2022

Conversation

hellofanny
Copy link
Contributor

@hellofanny hellofanny commented Jun 16, 2022 •
edited
Loading

What's the purpose of this pull request?

General improvements on Storybook.

How does it work?

  • Displays the Sandbox tab: so we can test viewports and use other addons (Accessibility)
  • Adds project's viewports to help with components' resizes tests
    preview-tab
  • Fixes some console errors:
    - Importing from '@storybook/addon-docs/blocks' is deprecated.
    - Adds OnChange handler to components examples (Checkbox, Radio, Toggle)
    image

How to test it?

  • Check on the preview if Sandbox and Docs tabs are available (except Getting Started, Theming, and Fundamentals pages)
  • When switching tabs, Sandbox might not be working properly until you reload the page.
    There is a note on the Getting Started's page regarding this issue
    image

References

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 17, 2022 at 5:23PM (UTC)

@vercel vercel bot temporarily deployed to preview June 16, 2022 14:55 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 16, 2022 •
edited
Loading

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-8868f37--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 8868f37

@vercel vercel bot temporarily deployed to preview June 16, 2022 15:09 Inactive
@vercel vercel bot temporarily deployed to preview June 17, 2022 00:29 Inactive
@vercel vercel bot temporarily deployed to preview June 17, 2022 01:28 Inactive
@vercel vercel bot temporarily deployed to preview June 17, 2022 02:35 Inactive
@hellofanny hellofanny changed the title Chore/storybook improvements Chore: storybook improvements Jun 17, 2022
@hellofanny hellofanny self-assigned this Jun 17, 2022
@hellofanny hellofanny added Bug Fixes Something isn't working Chore General tasks. labels Jun 17, 2022
@vercel vercel bot temporarily deployed to preview June 17, 2022 03:00 Inactive
@hellofanny hellofanny removed the Bug Fixes Something isn't working label Jun 17, 2022
@hellofanny hellofanny marked this pull request as ready for review June 17, 2022 03:02
@vtex-sites
Copy link

vtex-sites bot commented Jun 17, 2022 •
edited
Loading

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 8868f37

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

eduardoformiga
eduardoformiga approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@eduardoformiga eduardoformiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UUU Pretty neat! ❤️

@hellofanny hellofanny requested a review from renatamottam June 17, 2022 16:04
renatamottam
renatamottam approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING improvement to the project 💛

@hellofanny hellofanny added the Features New feature or request label Jun 17, 2022
@vercel vercel bot temporarily deployed to preview June 17, 2022 17:14 Inactive
@vercel vercel bot temporarily deployed to preview June 17, 2022 17:23 Inactive
@hellofanny hellofanny merged commit 8868f37 into main Jun 17, 2022
@hellofanny hellofanny deleted the chore/storybook-improvements branch June 17, 2022 18:38
@hellofanny hellofanny mentioned this pull request Jun 17, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatamottam renatamottam renatamottam approved these changes

@eduardoformiga eduardoformiga eduardoformiga approved these changes

@filipewl filipewl filipewl approved these changes

Assignees

@hellofanny hellofanny

Labels
Chore General tasks. Features New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hellofanny @filipewl @eduardoformiga @renatamottam