Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extract RegionalizationModal #128

Merged
merged 7 commits into from
Jun 23, 2022
Merged

feat: Extract RegionalizationModal #128

merged 7 commits into from
Jun 23, 2022

Conversation

ArthurTriis1
Copy link
Contributor

@ArthurTriis1 ArthurTriis1 commented Jun 16, 2022 •
edited
Loading

Signed-off-by: Arthur Andrade [email protected]## What's the purpose of this pull request?

What's the purpose of this pull request?

How does it work?

Before Now
Screen Shot 2022-06-16 at 14 02 01 Screen Shot 2022-06-16 at 13 58 45

Tokens applied for RegionalizationModal and Modal.

How to test it?

  • Check the RegionalizationModal documentation in the preview
  • Check the Modal documentation in the preview

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 23, 2022 at 3:00PM (UTC)

@vercel vercel bot temporarily deployed to preview June 16, 2022 14:40 Inactive
@ArthurTriis1 ArthurTriis1 force-pushed the feat/add-tokens-to-RegionModal branch from 4128698 to 64ecc02 Compare June 16, 2022 14:52
@vercel vercel bot temporarily deployed to preview June 16, 2022 14:53 Inactive
@ArthurTriis1 ArthurTriis1 force-pushed the feat/add-tokens-to-RegionModal branch from 64ecc02 to 383f4c7 Compare June 16, 2022 15:10
@vercel vercel bot temporarily deployed to preview June 16, 2022 15:12 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 16, 2022 •
edited
Loading

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-3a201f4--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 3a201f4

@vtex-sites
Copy link

vtex-sites bot commented Jun 16, 2022 •
edited
Loading

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 0b97ae7

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

@ArthurTriis1 ArthurTriis1 added the Features New feature or request label Jun 16, 2022
@ArthurTriis1 ArthurTriis1 marked this pull request as draft June 16, 2022 17:09
@vercel vercel bot temporarily deployed to preview June 16, 2022 17:12 Inactive
@ArthurTriis1 ArthurTriis1 force-pushed the feat/add-tokens-to-RegionModal branch from 39d13db to e8e400e Compare June 16, 2022 17:14
@ArthurTriis1 ArthurTriis1 marked this pull request as ready for review June 16, 2022 17:14
@ArthurTriis1 ArthurTriis1 self-assigned this Jun 16, 2022
@vercel vercel bot temporarily deployed to preview June 16, 2022 17:15 Inactive
lucasfp13
lucasfp13 reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@lucasfp13 lucasfp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements!

Left some points to discuss.

src/components/regionalization/RegionalizationModal/RegionalizationModal.stories.mdx Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/RegionalizationModal.tsx Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/RegionalizationModalContent.tsx Outdated Show resolved Hide resolved
src/components/ui/Modal/Modal.stories.mdx Show resolved Hide resolved
src/components/ui/Modal/Modal.stories.mdx Show resolved Hide resolved
src/components/ui/Modal/modal.module.scss Outdated Show resolved Hide resolved
renatamottam
renatamottam reviewed Jun 20, 2022
View reviewed changes
src/components/regionalization/RegionalizationModal/RegionalizationModal.stories.mdx Outdated Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/regionalization-modal-content.module.scss Outdated Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/regionalization-modal-content.module.scss Outdated Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/RegionalizationModal.stories.mdx Outdated Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/RegionalizationModal.stories.mdx Outdated Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/regionalization-modal-content.module.scss Outdated Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/RegionalizationModal.stories.mdx Outdated Show resolved Hide resolved
src/components/regionalization/RegionalizationModal/RegionalizationModal.stories.mdx Show resolved Hide resolved
@ArthurTriis1 ArthurTriis1 force-pushed the feat/add-tokens-to-RegionModal branch from e8e400e to cd34aa6 Compare June 21, 2022 15:36
@vercel vercel bot temporarily deployed to preview June 21, 2022 15:39 Inactive
@ArthurTriis1
fix: Apply adjusts in Modal
0926d99 
Signed-off-by: Arthur Andrade <[email protected]>
@ArthurTriis1 ArthurTriis1 force-pushed the feat/add-tokens-to-RegionModal branch from cd34aa6 to 0926d99 Compare June 21, 2022 15:40
@vercel vercel bot temporarily deployed to preview June 21, 2022 15:42 Inactive
@ArthurTriis1
fix: Apply adjusts in Modal
a0db3f3 
Signed-off-by: Arthur Andrade <[email protected]>
@vercel vercel bot temporarily deployed to preview June 21, 2022 20:01 Inactive
hellofanny
hellofanny approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done! It looks good to goooo 🚀 🚀

@vercel vercel bot temporarily deployed to preview June 22, 2022 15:53 Inactive
@ArthurTriis1 ArthurTriis1 force-pushed the feat/add-tokens-to-RegionModal branch from 8fb7feb to 1cce832 Compare June 22, 2022 15:56
@vercel vercel bot temporarily deployed to preview June 22, 2022 15:57 Inactive
renatamottam
renatamottam approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@vercel vercel bot temporarily deployed to preview June 23, 2022 15:00 Inactive
@ArthurTriis1 ArthurTriis1 merged commit 3a201f4 into main Jun 23, 2022
@ArthurTriis1 ArthurTriis1 deleted the feat/add-tokens-to-RegionModal branch June 23, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfp13 lucasfp13 lucasfp13 left review comments

@danzanzini danzanzini danzanzini left review comments

@renatamottam renatamottam renatamottam approved these changes

@hellofanny hellofanny hellofanny approved these changes

@eduardoformiga eduardoformiga Awaiting requested review from eduardoformiga

@filipewl filipewl Awaiting requested review from filipewl

@carolinamenezes carolinamenezes Awaiting requested review from carolinamenezes

Assignees

@ArthurTriis1 ArthurTriis1

Labels
Features New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArthurTriis1 @hellofanny @danzanzini @renatamottam @lucasfp13