-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Page error codes #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tlgimenes
force-pushed
the
feat/export-errors
branch
from
June 10, 2022 18:23
cc6eaaa
to
8aca7c1
Compare
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-c248449--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit c248449
|
eduardoformiga
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR fixes a bug introduced on #88. Also, fixes one of the TODOs regarding GraphQL status code.
How does it work?
#88 fixed wrong 404s on PDPs when an error occurred between
function
->ecommerce API
. This fix, however, didn't take into account that users entering wrong slugs should still get a 404, not a 500. This PR fixes all of these problems.To way it works is that now it reads the error status thrown inside
@faststore/api
before returning the response.How to test it?
/4k-philips-monitor-99988213/p
/4k-philips-monitor-99988213/p
you should get a 200 with the right page being renderedReferences
Also, check the reference PR on @faststore/api