Feat: [Refinements] Creates ShippingSimulation
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tweaks PDP grid * Creates shipping simulation component * Adds ShippingSimulation parts and styles * Tweaks PDP grid * Updates input text clear button control * Adds conditional rendering and session checking * Renames from Zip code to Postal Code * Makes Postal Code link text uniform * Themification ShippingSimulation * Organizes ShippingSimulation component * Manages simulation state using single object * Adds CHANGELOG entry * Creates Stories * removes stories folder * Fixes sonarQube * Trigger CI * Extracts code into new hook that uses useReducer * Removes -tablet from tokens * Tweaks border radius Co-authored-by: Fanny Chien <[email protected]> * Tweaks font-size token * Removes too specific token * Tweaks tokens spaces * Removes SessionProvider from stories Co-authored-by: Fanny Chien <[email protected]>
renatamottam
added
Documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 2c6fc90
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR aims to create and refine the
ShippingSimulationthat is found in the PDP.This task didn't include API integration. Thus, we are using mocked data just to see the component working as expected.
Tasks:
How does it work?
👀 One behavior to pay attention to:
PostalCodeincluded in its session, the page should load thisPostalCodein theShippingSimulationas the default.PostalCodein its session while in thePDPusing theRegionalizationfeature, the page should load thisPostalCodeonly if there is noPostalCodeincluded in theShippingSimulation. But as we don't save thePostalCodefrom theShippingSimulation, if the user refreshes the page, the one from the session must override the other from theShippingSimulation.How to test it?
So far, we are using mocked data, but you can play around inside the
PDP. If something didn't work properly (because we are using a user session), try to clean theIndexDBdata.You can also see the storybook.
References
https://www.figma.com/file/EYJqnbWByrSX9EMKvBzBLm/22%2F06%2F14-Handoff-for-PDP-Components?node-id=1001%3A131786
https://www.figma.com/file/EYJqnbWByrSX9EMKvBzBLm/22%2F06%2F14-Handoff-for-PDP-Components?node-id=1001%3A152727
https://vtex-dev.atlassian.net/jira/software/projects/FS/boards/632?selectedIssue=FS-475
Checklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should come first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation