Feat: Theming Brandless #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes Incentives text color * Improves text display on Hero and BannerText * Fixes ProductShelf padding top * Fixes tokens typo of button-buy * Improves ProductCard tokens * Creates Brandless theme * Fixes color actions tokens * Fixes ProductCard border * Updates global Tokens to match Brandless style * Removes Lato from Typography doc * Fixes Toggle tokens with Brandless * Creates two new themes * Fixes Border Color hover token
* Fixes `SectionListProps` * Fixes `Tiles` border-radius * Adds missing TokenColor on Interactive Controls page * Removes commented tokens from `CustomTheme` * Fixes theme class on body * Fixes `CartToggle` background color * Adds links between `SlideOver` Use Cases components * Fixes product-listing-pagination section * Removes Themes dependencies * Creates Themes pages * Fixes `Alert` bkg * Updates Changelog * Adds `TokenTable` to `Typography` page * Fixes Theme Section Storybook classes * Improves `Typography` doc page * Improves `Theme` doc pages titles Co-Authored-By: Fanny Chien <[email protected]> * Updates `Customizing` copy Co-authored-by: Fanny Chien <[email protected]> * Updates Changelog Co-authored-by: Fanny Chien <[email protected]> Co-authored-by: Fanny Chien <[email protected]> Co-authored-by: Fanny Chien <[email protected]>
renatamottam
added
Documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-156--gatsby.preview.vtex.app |
renatamottam
requested review from
eduardoformiga,
lucasfp13,
ArthurTriis1 and
hellofanny
…s/gatsby.store into feat/theming-brandless
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 751a2f0
|
filipewl
approved these changes
Jul 22, 2022
eduardoformiga
approved these changes
Jul 22, 2022
hellofanny
reviewed
Jul 25, 2022
There was a problem hiding this comment.
Niceee! 🚀 @renatamottam
Just a question: Is there any place that we mention the meaning of the alert icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR tests and improves the Theming proposal. We extracted all BaseStore visual to a new theme called
soft-blueand left global tokens more clean. We also added a new theme for testing purposes, it's calledmidnight.Additionally, we updated Storybook doc with more sections and descriptions.
How does it work?
Now you can create
themes!Just create a new .scss file on
src/styles/themesand overwrite the tokens you want.We created two themes to use as examples:
soft-blueandmidnight.How to test it?
Checkout our new Storybook, with a special attention to: Getting Started, Customizing and Typography.
Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.Documentation