-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add css modules, tokens and refactor Search
components
#150
Conversation
Signed-off-by: Arthur Andrade <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-150--gatsby.preview.vtex.app |
Search
components
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because it's has the same changes made on vtex-sites/nextjs.store#173 👍
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 85406bb
|
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
Signed-off-by: Arthur Andrade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Arthur Andrade [email protected]
What's the purpose of this pull request?
How does it work?
This PR renames the components from Search feature to follow the Pattern
Search[ComponentName]
, and relocates the components to group in search folder, as that's components share the same states provided foruseInputSearch
and belong to the same feature.The refactored components are:
Also, this PR adds tokens to
SearchHistory
, but when it was done, it was perceived that theSearchHistory
style is shared withSearchTop
,SearchDropdown
andSearchSuggestions
, so file src/components/search/search-common.module.scss was created to be added to these 4 components.To finish, storybook documentation was created for all search components, with an Overview documentation for the feature using API mocks add-on.
How to test it?
To test, you can check the feature Search in storybook documentation and check the style and behaviours of the feature in preview.
Checklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation