fix: SonarQube warnings/error #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-7a99d4f--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 7a99d4f
|
eduardoformiga
changed the title
8 tasks
filipewl
approved these changes
Jul 11, 2022
eduardoformiga
added a commit
that referenced
this pull request
Jul 12, 2022
* Feat: Adds tokens to `SlideOver` (#145) * Uses CSS Modules on SlideOver component with themification * Extracts FilterSliderComponent * Extracts FilterSlider components and uses CSS Modules and tokens * Adds CSS Modules to Accordion * Adds Accordion theming tokens * Adds Changelog Entry * Moves styles to accordion component * Creates Accordion stories * Adds Accordion stories * Adds tokens to facets * Adds tokens to Filter Slider * Creates Filter Stories * Removes unused imports from Filter stories * Adds Filter facet description * Creates facets stories * Removes unused import from facets stories * Crestes FilterSlider stories * Adds CHANGELOG entry * Updates Filter related stories with PriceRange changes * Updates Filter related components links on storybook * Extracts Navbar related components and uses CSS Modules * Updates README navbar example * Adds tokens to navbar * Adds tokens to navlinks * Adds tokens to NavbarSlider * Tweaks navbar module comments * Adds CHANGELOG entry * Tweaks tokens spaces * Creates Navbar stories * Creates NavbarSlider stories * Creates NavLinks stories * Updates navbar related components links * Adds tokens to cart sidebar * Adds CHANGELOG entry * Adds tokens to cart sidebar * Moves facets mock to own file * Creates SlideOver stories * Tweaks breakpoint tokens * Removes height token * Removes some tokens * Updates SlideOver usage stories and props descriptions * Tweaks bkg color token Co-authored-by: Renata Motta <[email protected]> * Removes full width token * Uses Button with icon to show SlideOver and Navbar * uses SectionList on SlideOver stories * Update src/components/cart/CartSidebar/CartSidebar.tsx Co-authored-by: Victor Hugo Miranda Pinto <[email protected]> * Update src/components/ui/SlideOver/SlideOver.tsx Co-authored-by: Victor Hugo Miranda Pinto <[email protected]> Co-authored-by: Renata Motta <[email protected]> Co-authored-by: Victor Hugo Miranda Pinto <[email protected]> * Adds CHANGELOG entry * Adds overlay css to global layout file * Adds CHANGELOG entry Co-authored-by: Renata Motta <[email protected]> Co-authored-by: Victor Hugo Miranda Pinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
ported from vtex-sites/nextjs.store#127
But also fixes:
Checklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#12)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation