Feat: Add tokens to SuggestionProductCard
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Arthur Andrade <[email protected]>
ArthurTriis1
force-pushed
the
feat/FSSS-383-Add-tokens-to-SuggestionProductCard
branch
from
3734185 to
2b97795
Compare
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-b38c741--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit b38c741
|
ArthurTriis1
added
Documentation
ArthurTriis1
changed the title
SuggestionProductCard
eduardoformiga
approved these changes
Jul 4, 2022
| @@ -0,0 +1,2 @@ | |||
| export { product } from './product' | |||
There was a problem hiding this comment.
Nice! Could you please update it on Nextjs starter as well if it's not too much work?
I noticed there we have mocks and mock folders.
There was a problem hiding this comment.
Yeah! I'm opening the PR!
ArthurTriis1
deleted the
feat/FSSS-383-Add-tokens-to-SuggestionProductCard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Andrade [email protected]
What's the purpose of this pull request?
This PR applies the new Theming structure to
SuggestionProductCard: new scoped tokens linked to global ones.How to test it?
You can check the story on Storybook.
Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation