Feat: Adds new tokens to Navbar
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extracts Navbar related components and uses CSS Modules * Updates README navbar example * Adds tokens to navbar * Adds tokens to navlinks * Adds tokens to NavbarSlider * Tweaks navbar module comments * Adds CHANGELOG entry * Tweaks tokens spaces * Creates Navbar stories * Creates NavbarSlider stories * Creates NavLinks stories * Updates navbar related components links * Update src/components/common/Navbar/Navbar.stories.mdx Co-authored-by: Fanny Chien <[email protected]> * Removes logo img tokens * Tweaks border color * Tweaks token name * Tweaks tokens names * Groups row token * Tweaks transition tokens * Tweaks storybook content width * Adjusts navbar tokens * Tweaks Navlinks style * Uses SectionList on navbar stories * Tweaks token stories * Applies token breakpoint name at the end * Removes row width token * Removes button collapse token * Removes button cart token * Removes overflow token * Update src/components/common/Navbar/NavbarSlider.stories.mdx Co-authored-by: Renata Motta <[email protected]> * Tweaks navlinks tokens * Trigger CI * Removes sign-in tokens * Tweaks border color token * Update src/components/common/Navbar/NavLinks.stories.mdx Co-authored-by: Renata Motta <[email protected]> Co-authored-by: Fanny Chien <[email protected]> Co-authored-by: Renata Motta <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eduardoformiga
added
Documentation
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-8909b7b--gatsby.preview.vtex.app |
eduardoformiga
requested review from
lucasfp13,
ArthurTriis1,
hellofanny,
renatamottam and
a team
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 8909b7b
|
renatamottam
approved these changes
Jul 1, 2022
hellofanny
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR applies the new Theming structure to
Navbar: new scoped tokens linked to global ones.It also refactors and split the navbar-related components as
NavbarSliderto its own file.How does it work?
This PR uses local variables to parameterize the
Navbarproperties, then connects these scoped tokens to the global ones.Tokens can be visualized in the storybook.
How to test it?
Navbarcomponent and its related components should look just as it was before these changes.Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation