-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Modal
and add tokens
#123
Conversation
Signed-off-by: Arthur Andrade <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-d86753a--gatsby.preview.vtex.app |
Signed-off-by: Arthur Andrade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving cuz it looks the same from NextJS.Store
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit d86753a
|
Co-authored-by: Fanny Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modal
and add tokens
Signed-off-by: Arthur Andrade [email protected]
What's the purpose of this pull request?
Modal
component fromRegionalizationModal
Modal
andRegionalizationModal
: new scoped tokens linked to global ones.How does it work?
Tokens applied for
RegionalizationModal
andModal
.How to test it?
RegionalizationModal
documentation in the previewModal
documentation in the previewChecklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation