Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Modal and add tokens #123

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Conversation

ArthurTriis1
Copy link
Contributor

@ArthurTriis1 ArthurTriis1 commented Jun 27, 2022

Signed-off-by: Arthur Andrade [email protected]

What's the purpose of this pull request?

How does it work?

Before Now
Screen Shot 2022-06-16 at 14 02 01 Screen Shot 2022-06-16 at 13 58 45

Tokens applied for RegionalizationModal and Modal.

How to test it?

  • Check the RegionalizationModal documentation in the preview
  • Check the Modal documentation in the preview

Checklist

You may erase this after checking them all ;)

Changelog

  • Added an entry in the CHANGELOG.md at the beginning of its due section. The latest version should comes first.
  • Added the PR number with the PR link at the entry in the CHANGELOG.md. E.g., New items in the pull_request_template.md (#4)

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

@vercel
Copy link

vercel bot commented Jun 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gatsby-store-storybook ✅ Ready (Inspect) Visit Preview Jun 27, 2022 at 7:32PM (UTC)

@vtex-sites
Copy link

vtex-sites bot commented Jun 27, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-d86753a--gatsby.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit d86753a

Signed-off-by: Arthur Andrade <[email protected]>
Copy link
Collaborator

@renatamottam renatamottam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving cuz it looks the same from NextJS.Store

@vtex-sites
Copy link

vtex-sites bot commented Jun 27, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit d86753a

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Fanny Chien <[email protected]>
Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving looks the same as on the next.js repo.

It is just missing an adjustment on the Use Cases section that will be addressed in another PR 😄

image

@renatamottam renatamottam changed the title Extract Modal and add tokens Extract Modal and add tokens Jun 27, 2022
@ArthurTriis1 ArthurTriis1 merged commit d86753a into main Jun 27, 2022
@ArthurTriis1 ArthurTriis1 deleted the feat/add-tokens-to-RegionModal branch June 27, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants