This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Theming's global tokens #407
Add Theming's global tokens #407
Changes from all commits
3361bc5
95d8ac3
c8de61c
ca03236
d4b5b47
473ebb6
76efe75
0d88e3b
b7c1d8d
0401e20
b703e90
14c373a
0b90c7b
37c5b68
1f45364
e560b55
7a97689
905e819
0aa0d83
478818f
ca87542
c9c6de3
da19656
ec19c5d
899ace8
0e42719
5fcfbfe
493fe33
8ea9d38
f6ee4c8
1b372e9
922448a
2d116a5
5f612e7
c19b590
75cc992
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't background also a type? Or is just a state 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it's a
typecategory.Edit: sorry for the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, so to follow the pattern shouldn't it be
--fs-bkg-color-primary
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, no. The type is indicated by the prefixes
-color
and-primary
;-color
refers to the Branding Core class, while-primary
refers to its hierarchical subgroup; finally,-bkg
refers to the actual property (category). Because this is a semantic phrasing arrangement, we must occasionally deviate from pure CSS syntax to make sense of these groupings.