-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes of i18n on readme.md #374
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eduardoformiga @lucasfp13 @lariciamota I need a hand here. There is one required test that I am not able to run. Any sugestions? |
Hello @danzanzini @natanfernandes and @filipewl. I tagged you as reviewers because I am having an issue with merging this PR. Different from other Apps, with this one I am not able to pass the PR actions / Lint (pull_request) test and unsure how to fix it. And since it looks like the errors causing the failing are on files that I have not eddited, I am not sure if I should touch them since this PR is supposed to be a simple documentation fix. |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Relates to task LOC-10552.
How to test it?
[Workspace](Link goes here!)
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)