Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes of i18n on readme.md #374

Merged
merged 2 commits into from
May 3, 2023
Merged

fixes of i18n on readme.md #374

merged 2 commits into from
May 3, 2023

Conversation

GeorgeLimaDev
Copy link
Contributor

@GeorgeLimaDev GeorgeLimaDev commented Apr 25, 2023

What problem is this solving?

Relates to task LOC-10552.

How to test it?

[Workspace](Link goes here!)

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@GeorgeLimaDev GeorgeLimaDev requested review from a team as code owners April 25, 2023 12:09
@GeorgeLimaDev GeorgeLimaDev requested review from eduardoformiga and removed request for a team April 25, 2023 12:09
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 25, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

Copy link

@karenkrieger karenkrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GeorgeLimaDev
Copy link
Contributor Author

GeorgeLimaDev commented Apr 27, 2023

@eduardoformiga @lucasfp13 @lariciamota I need a hand here. There is one required test that I am not able to run. Any sugestions?

@GeorgeLimaDev
Copy link
Contributor Author

Hello @danzanzini @natanfernandes and @filipewl. I tagged you as reviewers because I am having an issue with merging this PR. Different from other Apps, with this one I am not able to pass the PR actions / Lint (pull_request) test and unsure how to fix it. And since it looks like the errors causing the failing are on files that I have not eddited, I am not sure if I should touch them since this PR is supposed to be a simple documentation fix.

@carolinamenezes carolinamenezes merged commit 6ac13f9 into master May 3, 2023
@carolinamenezes carolinamenezes deleted the fix/loc/10552 branch May 3, 2023 18:33
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented May 3, 2023

Your PR has been merged! App is being published. 🚀
Version 2.83.0 → 2.83.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants