Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/code reference minicart #84

Merged

Conversation

LucasCastroAcctGlobal
Copy link
Contributor

What problem is this solving?

Currently, the product-list component does not have an option to pull reference IDs for a product.

How to test it?

  1. Enter Workspace and add products to cart

  2. De acordo com o valor passado na propriedade identifierOption, a informação escolhida será mostrada.

Workspace

Screenshots or example usage:

https://flic.kr/p/2jXEmvZ

@LucasCastroAcctGlobal LucasCastroAcctGlobal requested review from a team as code owners October 21, 2020 17:19
@LucasCastroAcctGlobal LucasCastroAcctGlobal requested review from darlenedms and wdsrocha and removed request for a team October 21, 2020 17:19
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 21, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@LucasCastroAcctGlobal LucasCastroAcctGlobal requested review from icazevedo, kaisermann, vitorflg and dvm1984 and removed request for a team October 21, 2020 17:19
@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

docs/README.md Outdated Show resolved Hide resolved
@kaisermann kaisermann requested a review from victorhmp November 5, 2020 19:40
react/ProductReference.tsx Outdated Show resolved Hide resolved
react/ProductReference.tsx Outdated Show resolved Hide resolved
react/constants/Identifiers.ts Outdated Show resolved Hide resolved
@LucasCastroAcctGlobal
Copy link
Contributor Author

@kaisermann can you help me fix the component lint errors, please?

I need the PR to be approved as soon as possible

@kaisermann
Copy link
Contributor

@LucasCastroAcctGlobal There are no more lint errors related to your PR, don't worry about them. We just need approval from the tech-writers team and from another developer.

@LucasCastroAcctGlobal
Copy link
Contributor Author

@LucasCastroAcctGlobal There are no more lint errors related to your PR, don't worry about them. We just need approval from the tech-writers team and from another developer.

@LucasCastroAcctGlobal There are no more lint errors related to your PR, don't worry about them. We just need approval from the tech-writers team and from another developer.

@kaisermann Thanks for the quick response.

Can you guys prioritize this approval?

Our customer needs the solution available as soon as possible.

react/ProductReference.tsx Outdated Show resolved Hide resolved
@kaisermann kaisermann merged commit d9db624 into vtex-apps:master Nov 12, 2020
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 12, 2020

Your PR has been merged! App is being published. 🚀
Version 0.25.0 → 0.26.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants