Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product quantity component #44

Merged
merged 5 commits into from
Mar 6, 2020
Merged

Add product quantity component #44

merged 5 commits into from
Mar 6, 2020

Conversation

lucasecdb
Copy link
Contributor

@lucasecdb lucasecdb commented Mar 6, 2020

What problem is this solving?

Adds the product quantity component that will be used in the new checkout. This PR also adds the showListPrice prop to the Price component, since we don't want to show it in the checkout listing.

Related clubhouse story

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).

Screenshots or example usage

image

Type of changes

✔️ Type of Change
_ Bug fix
✔️ New feature
_ Breaking change
_ Technical improvements

@lucasecdb lucasecdb requested a review from a team March 6, 2020 13:47
@lucasecdb lucasecdb self-assigned this Mar 6, 2020
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 6, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Mar 6, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

react/ProductQuantity.tsx Outdated Show resolved Hide resolved
@lucasecdb lucasecdb merged commit e0f20eb into master Mar 6, 2020
@lucasecdb lucasecdb deleted the feat/product-quantity branch March 6, 2020 16:32
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 6, 2020

Your PR has been merged! App is being published. 🚀
Version 0.17.0 → 0.18.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants