Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vbase client to persist responses #30

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Add vbase client to persist responses #30

merged 1 commit into from
Nov 18, 2021

Conversation

mcandeia
Copy link
Contributor

@mcandeia mcandeia commented Nov 18, 2021

What problem is this solving?

How should this be manually tested?

Screenshots or example usage:

#trivial

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 18, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 18, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

authorization
)

if (persistedResponse !== undefined && persistedResponse !== null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do something like if (!!persistedResponse) instead of this bigger expression or use !isNil(persistedResponse) in case you already using ramda is this project.

Copy link

@gugabribeiro gugabribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion!

@mcandeia mcandeia merged commit 73c7eff into master Nov 18, 2021
@mcandeia mcandeia deleted the remove/loop branch November 18, 2021 14:24
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 18, 2021

Your PR has been merged! App is being published. 🚀
Version 1.0.5 → 1.0.6

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@vtex-io-docs-bot
Copy link

Beep boop 🤖 That's ok, I created an issue for this so we don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants