Adjust some price fields #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### What problem is this solving? It sends the [GA4 `select_promotion`](https://developers.google.com/analytics/devguides/collection/ga4/reference/events?hl=en&client_type=gtag#select_promotion) event when `vtex:promotionClick` is received. https://developers.google.com/analytics/devguides/collection/ga4/reference/events?hl=en&client_type=gtag#select_promotion| -| | #### How should this be manually tested? A new test has been added and can be run with `yarn test`. #### Types of changes * [ ] Bug fix (a non-breaking change which fixes an issue) * [x] New feature (a non-breaking change which adds functionality) * [ ] Breaking change (fix or feature that would cause existing functionality to change) * [ ] Requires change to documentation, which has been updated accordingly.
#### What is the purpose of this pull request? Implements the update function working as described on [docs](https://developers.google.com/tag-manager/ecommerce-ga4?hl=pt-br#measure_promotion_clicks) and following the line implemented in [faststore](https://github.com/vtex-sites/nextjs.store/blob/chore/add-sentry/src/sdk/analytics/index.tsx#L18:L18), isolating the event data and update the event with the correct body #### What problem is this solving? Send the events to `window.dataLayer` in the correct format #### How should this be manually tested? check if the events in dataLayer are in the correct format `{event: ..., ecommerce: { ... } }` #### Screenshots or example usage #### Types of changes * [ ] Bug fix (a non-breaking change which fixes an issue) * [X] New feature (a non-breaking change which adds functionality) * [ ] Breaking change (fix or feature that would cause existing functionality to change) * [ ] Requires change to documentation, which has been updated accordingly.
#### What is the purpose of this pull request? This PR intends to add the `add_to_cart` GA4 event to be sent when `vtex:addToCart` is received. [`add_to_cart` event](https://developers.google.com/analytics/devguides/collection/ga4/reference/events?hl=en&client_type=gtag#add_to_cart)| -| | #### How should this be manually tested? - In your local environment, inside the `google-tag-manager` app repository, go to the branch `feat/ga4-add-to-cart-event`; - Login in your preferred account and workspace; - Link the app; - Go to the Admin and access the App Store. Look for the Google Tag Manager app and access the `Settings`; - Check the `Merge Universal Analytics and Google Analytics 4 Events` option; - Access the store and perform add an item to the cart; - Check the `dataLayer` object (just type `dataLayer` in the console and press enter). The event data should be in the list.  #### Types of changes * [ ] Bug fix (a non-breaking change which fixes an issue) * [x] New feature (a non-breaking change which adds functionality) * [ ] Breaking change (fix or feature that would cause existing functionality to change) * [ ] Requires change to documentation, which has been updated accordingly.
#### What is the purpose of this pull request? This PR intends to add the `remove_from_cart` GA4 event to be sent when `vtex:removeFromCart` is received. [`remove_from_cart` event](https://developers.google.com/analytics/devguides/collection/ga4/reference/events?hl=en&client_type=gtag#remove_from_cart)| -| | #### How should this be manually tested? - In your local environment, inside the `google-tag-manager` app repository, go to the branch `feat/ga4-remove-from-cart-event`; - Login in your preferred account and workspace; - Link the app; - Go to the Admin and access the App Store. Look for the Google Tag Manager app and access the `Settings`; - Check the `Merge Universal Analytics and Google Analytics 4 Events` option; - Access the store and perform add an item to the cart; - Check the `dataLayer` object (just type `dataLayer` in the console and press enter). The event data should be in the list. #### Types of changes * [ ] Bug fix (a non-breaking change which fixes an issue) * [x] New feature (a non-breaking change which adds functionality) * [ ] Breaking change (fix or feature that would cause existing functionality to change) * [ ] Requires change to documentation, which has been updated accordingly.
#### What is the purpose of this pull request? This PR intends to add the `purchase` GA4 event to be sent when `vtex:orderPlaced` is received. [`purchase` event](https://developers.google.com/analytics/devguides/collection/ga4/reference/events?hl=pt-br&client_type=gtag#purchase)| -|  #### How should this be manually tested? - In your local environment, inside the `google-tag-manager` app repository, go to the branch `feat/ga4-remove-from-cart-event`; - Login in your preferred account and workspace; - Link the app; - Go to the Admin and access the App Store. Look for the Google Tag Manager app and access the `Settings`; - Check the `Merge Universal Analytics and Google Analytics 4 Events` option; - Access the store and perform add an item to the cart and complete a checkout; - Check the `dataLayer` object (just type `dataLayer` in the console and press enter). The event data should be in the list. #### Types of changes * [ ] Bug fix (a non-breaking change which fixes an issue) * [x] New feature (a non-breaking change which adds functionality) * [ ] Breaking change (fix or feature that would cause existing functionality to change) * [ ] Requires change to documentation, which has been updated accordingly.
#### What problem is this solving? Push the GA4's [`view_promotion`](https://developers.google.com/analytics/devguides/collection/ga4/reference/events?hl=en&client_type=gtag#view_promotion) event when `vtex:promoView` is triggered. #### How to test? 1. Visit https://filipelimaxga4viewpromo--storecomponents.myvtex.com/. 2. Click the right arrow button to see the next gallery image. 3. Check the `dataLayer` variable in the web console to ensure the `view_promotion` was fired. 
We initially thought we needed to merge both events, but in the end we decided to push them separately so this new wording reflects better what's happening.
|){kind=link}
|){kind=link}
|){kind=link}
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
#### What problem is this solving? - Add tests to GA4 `select_item`, `view_item`, and `view_item_list` events. - Remove unused types `CategoryTreeItem` and `CategoryTree`. - Stop exporting the util function `removeStartAndEndSlash` because it's only used internally. - Type event payloads for better safety. #### How should this be manually tested? Run new and existing tests with `yarn test`.
Base automatically changed from
chore/clean-up-2
to
feat/settings-merge-ua-events
March 2, 2023 16:31
We had added `PriceWithoutDiscount`, but after double checking real data, we found not all events send in this field, so we cannot reliably use that. `ListPrice` has the original price, and `Price` has the price with discount, so we can simply subtract them.
`CommertialOffer`'s `Price` returns the price **with** discount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
Review all events and make sure we're using correct values for
value, and items'priceanddiscountfields.