Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/migration #4

Merged
merged 5 commits into from
Oct 3, 2019
Merged

Feature/migration #4

merged 5 commits into from
Oct 3, 2019

Conversation

lbebber
Copy link
Contributor

@lbebber lbebber commented Oct 2, 2019

What does this PR do? *

Adds migrationFrom option

How to test it? *

Describe alternatives you've considered, if any. *

Related to / Depends on *

@lbebber lbebber requested review from victorhmp and a team October 2, 2019 22:36
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 2, 2019 •
edited by lbebber
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

jgfidelis
jgfidelis previously approved these changes Oct 3, 2019
View reviewed changes
iaronaraujo
iaronaraujo previously approved these changes Oct 3, 2019
View reviewed changes
victorhmp
victorhmp reviewed Oct 3, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
victorhmp
victorhmp reviewed Oct 3, 2019
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
victorhmp
victorhmp previously approved these changes Oct 3, 2019
View reviewed changes
@victorhmp
Copy link
Contributor

@lbebber that issue with duplicated classes being added is actually not a bug, it's just that if you pass migrationFrom with the same app name as the original one being added, it would add it twice, as expect.
Maaaaybe there could be a verification to prevent this, but I don't think it's necessary

@lbebber lbebber dismissed stale reviews from victorhmp, iaronaraujo, and jgfidelis via 0e4f1e9 October 3, 2019 18:30
@lbebber lbebber force-pushed the feature/migration branch from 2d18697 to 0e4f1e9 Compare October 3, 2019 18:30
@lbebber
Copy link
Contributor Author

lbebber commented Oct 3, 2019

@victorhmp It now refrains from repeating a migration app if it happens to be the same as the current one; please review again

@lbebber lbebber merged commit e2e0446 into master Oct 3, 2019
@lbebber lbebber deleted the feature/migration branch October 3, 2019 18:52
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 3, 2019

Your PR has been merged! App is being published. 🚀
Version 0.2.1 → 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorhmp victorhmp victorhmp approved these changes

@iaronaraujo iaronaraujo iaronaraujo approved these changes

@jgfidelis jgfidelis jgfidelis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbebber @victorhmp @jgfidelis @iaronaraujo