@Directive @Input('<') setter called before constructor

[kylekatarnls]

Hello,

I created a directive and noticed that @Input setter was called before the class to be constructed.

This prevents to use injected dependencies in those setters.

import {Directive, Input} from 'angular-ts-decorators';

@Directive({
    selector: 'foo-disabled',
})
export class FooDisabledDirective {
    @Input('<') public set fooDisabled(disabled: boolean) {
        console.log('fooDisabled', this.$element);
    }

    constructor(private $element: ng.IAugmentedJQuery) {
        console.log('construct', $element);
    }
}

<div foo-disabled="5 == 5"></div>

Observed in console:

fooDisabled, undefined
construct, <div foo-disabled="5 == 5"></div>

Expected:

construct, <div foo-disabled="5 == 5"></div>
fooDisabled, <div foo-disabled="5 == 5"></div>

Expected order is the one we get in Angular 2+.

In my opinion, this is a bug. I'm not sure to be able to fix it but I can try to make a pull-request if you're agree to fix it.

Thanks.

[vsternbach]

You shouldn't be accessing $element in constructor according to angular, it should be done in ngOnInit hook

[kylekatarnls]

$element is not the problem, it would be the same with a service it won't be defined in the setter because the setter is called before the constructor. This is a non-sense. The constructor of a class should be called before any other method. because if the instance does not yet exists, I should be able to call any method.

Replace $element with $filter in the example above, and you'll get the same inconsistency: this.$filter is undefined because the setter is called before the constructor.

[vsternbach]

I see, what angularjs version are you using? There's an issue documented here angular/angular.js#14206

…

On Thu, May 23, 2019, 6:19 PM Kyle ***@***.***> wrote: $element is not the problem, it would be the same with a service it won't be defined in the setter because the setter is called before the constructor. This is a non-sense. The constructor of a class should be called before any other method. because if the instance does not yet exists, I should be able to call any method. Replace $element with $filter in the example above, and you'll get the same inconsistency: this.$filter is undefined because the setter is called before the constructor. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#102?email_source=notifications&email_token=AA5HHDBGZIAWMTVEUU53HW3PW2YW5A5CNFSM4HPCX32KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWCSAAQ#issuecomment-495263746>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5HHDGPVINL4S26L5R7RKTPW2YW5ANCNFSM4HPCX32A> .

[kylekatarnls]

I'm in the worst case (1.5.11):

In 1.5.10+, the default behavior will be to assign before calling the constructor, but you can change it to delay until before $onInit.

Indeed we should upgrade.

Thanks!

[kylekatarnls]

Thanks again for your quick response. We really love your library. ❤️