VRM10SpringBoneColliderGroup 改善 #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Santarh
requested changes
Nov 7, 2024
| return; | ||
| } | ||
|
|
||
| UnityEditor.Undo.IncrementCurrentGroup(); |
Santarh
approved these changes
Nov 7, 2024
| @@ -25,6 +25,7 @@ string GetName() | |||
| return Colliders[0].name; | |||
| } | |||
|
|
|||
| #if UNITY_EDITOR | |||
There was a problem hiding this comment.
本当は ifdef やめて Editor asmdef の方に Editor コードは書きたいところだけど
Gizmo や Menu の周りは結構どうしようもないときはあるんだよなあ。
There was a problem hiding this comment.
editor 側に移動しようかと思ったのだけど、
一個の GameObject に複数の同一 component がささっているときに対象を選択するには、
ContextMenu が楽なのでやむを得ない・・・。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnDrawGizmosSelectedで配下の collider を gizmo 描画する。context menu で子オブジェクトを作って、そっちに移動する。
これは、ひとつの secondary に複数の VRM10SpringBoneColliderGroup がアタッチされていると作業しづらいことに対する対策です。よさそうであれば、後に import 時に secondry の子オブジェクトを自動で作ってもよいかもしれない。