[springbone] SpringBone が無いモデルの NullReferenceException を修正 #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
changed the title
ousttrue
commented
Oct 16, 2024
| // Vrm10Runtime で初期化していたが、 async にするためこちらに移動 v0.127 | ||
| // RuntimeGltfInstance にアクセスしたいのだが OnLoadHierarchy ではまだ attach されてなかった v0.128 | ||
| // VRMC_springBone が無くても初期化する v0.127.2 | ||
| await m_springboneRuntime.InitializeAsync(controller, awaitCaller); |
There was a problem hiding this comment.
VRMC_springBone の有無と無関係に初期化する
ousttrue
commented
Oct 16, 2024
| { | ||
| m_service = SpringBoneJobs.FastSpringBoneService.Instance; | ||
| } | ||
|
|
There was a problem hiding this comment.
VRMC_springBone が無い時にも InitializeAsync するようにしたので、
無くても大丈夫になったが、初期化を遅延させる意味も無いので constructor。
ousttrue
commented
Oct 16, 2024
| Unregister(); | ||
| var task = RegisterAsync(new ImmediateCaller()); | ||
| var _ = RegisterAsync(new ImmediateCaller()); |
ousttrue
commented
Oct 16, 2024
| public Vrm10FastSpringboneRuntime() | ||
| { | ||
| m_fastSpringBoneService = FastSpringBones.FastSpringBoneService.Instance; | ||
| } |
There was a problem hiding this comment.
VRMC_springBone が無い時にも InitializeAsync するようにしたので、
無くても大丈夫になったが、初期化を遅延させる意味も無いので constructor。
ousttrue
commented
Oct 16, 2024
| { | ||
| m_fastSpringBoneService.BufferCombiner.Unregister(m_fastSpringBoneBuffer); | ||
| m_fastSpringBoneBuffer.Dispose(); | ||
| } |
There was a problem hiding this comment.
VRMC_springBone が無い時にも InitializeAsync するようにしたので、
無くても大丈夫になった。
ousttrue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
多段に NullReferenceException の可能性があるのでちょっと整理する。
という API でよさそう。