[Fix] FileInput & FileItem circular dependency #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
force-pushed
the
fix/fileinput-fileitem-circular-dependency
branch
from
2d140c1 to
cac0bcb
Compare
riitasointi
approved these changes
Dec 16, 2024
LJKaski
force-pushed
the
fix/fileinput-fileitem-circular-dependency
branch
from
cac0bcb to
4e852f0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon building there was a warning about a circular dependency between
FileInputandFileItem. It seemed to have originated from the shared class name object. Separating FileItem classes to reside in the correct file seems to have fixed the issue.How Has This Been Tested?
Tested by building locally and checking that the warning message no longer appears upon building.
Release notes
FileItem, FileInput