[Hotfix] Dropdown, SingleSelect & MultiSelect screen reader a11y #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
approved these changes
Nov 19, 2024
LJKaski
added a commit
that referenced
this pull request
Nov 28, 2024
…fixes [Hotfix] Dropdown, SingleSelect & MultiSelect screen reader a11y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR contains fixes for the Dropdown, SingleSelect & MultiSelect components. The changes to the Select components are mainly pre-emptive in nature and deal with the extra divs in the popover list.
Dropdown, on the other hand, needs a hotfix since the component is currently not working in the latest macOS version with Safari + VoiceOver. The fix is, fortunately, very simple: Just replace
aria-ownswitharia-controlsin the dropdown button.Motivation and Context
The issues were reported to us by an accessibility specialist.
How Has This Been Tested?
Styleguidist: macOS 15 with Safari + VO, Chrome + VO
Release notes
Dropdown
SingleSelect, MultiSelect
<ul>and<li>)ariaOptionsAvailableTextFunctiondocumentation examples