[Feature] Details component #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
force-pushed
the
feature/details-component
branch
from
0fc304c to
ff1ea74
Compare
riitasointi
requested changes
Jun 6, 2024
riitasointi
reviewed
Jun 6, 2024
LJKaski
force-pushed
the
feature/details-component
branch
from
1444de6 to
253dfc2
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new component, Details, that can be used for hiding and presenting information that is not essential to most users.
Motivation and Context
This component is already in use via separate implementation, so a centralized, uniform, implementation made sense.
How Has This Been Tested?
Tested locally in styleguidist on chrome and Windows, and in a React + Vite project on Chrome. Still needs more testing and accessibility testing especially.
Screenshots (if appropriate):
Release notes
Details
<Details>component