[Hotfix] Typing in callback function props #828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some overlap in typing related to callbacks such as
onChange
,onClick
andonBlur
. After the recent change of extending component props with relevant HTML props, the typings were accidentally changed in components where there were differing typings for the callbacks in the component APIs and the HTML props they extended.The issue was fixed by omitting the overlapping props from the extended HTML props.
Motivation and Context
There was an unintended change in typings which caused issues for developers.
How Has This Been Tested?
Tested in a React+Vite test project with latest Typescript to see if the issues were indeed fixed.
Release notes
onChange
,onClick
andonBlur
props in several components