Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Typing in callback function props #828

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

LJKaski
Copy link
Collaborator

@LJKaski LJKaski commented Feb 16, 2024

Description

This PR fixes some overlap in typing related to callbacks such as onChange, onClick and onBlur. After the recent change of extending component props with relevant HTML props, the typings were accidentally changed in components where there were differing typings for the callbacks in the component APIs and the HTML props they extended.

The issue was fixed by omitting the overlapping props from the extended HTML props.

Motivation and Context

There was an unintended change in typings which caused issues for developers.

How Has This Been Tested?

Tested in a React+Vite test project with latest Typescript to see if the issues were indeed fixed.

Release notes

  • Fix unintentionally changed typings in onChange, onClick and onBlur props in several components

@LJKaski LJKaski added the release Release label Feb 16, 2024
@LJKaski LJKaski self-assigned this Feb 16, 2024
@LJKaski LJKaski requested a review from riitasointi as a code owner February 16, 2024 10:41
@LJKaski LJKaski merged commit bc3a9fa into master Feb 16, 2024
1 check passed
LJKaski added a commit that referenced this pull request Feb 16, 2024
[Hotfix] Typing in callback function props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release
Projects
Development

Successfully merging this pull request may close these issues.

2 participants