[Feature] SingleSelect & MultiSelect: Add onChangeWithoutDebounce() #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new prop called
onChangeWithoutDebounce()
to<SingleSelect>
&<MultiSelect>
. The prop is basically the same asonChange()
but does not use the debounce time even if it is specified.Its inteded use case is mainly enabling the
loading
state of the component. It makes sense to show the loading spinner immediately when the user starts filtering and only make a backend call after a certain debounce time.In addition, this PR also fixes an oversight in the SingleSelect component
getDerivedStateFromProps()
logic. Previously, when the value of theitems
prop or theselectedItem
prop changed, the filter input's value was always set to an empty string''
. Now it only does that ifselectedItem
is set to null.Motivation and Context
It was reported by users that having the
loading
state of the component only be applied after the debounce time is not ideal. It causes the existing items to be filtered briefly by the new input before the loading process begins.How Has This Been Tested?
Styleguidist on Chrome & library's programmatic tests
Release notes
SingleSelect
items
orselectedItem
prop changesonChangeWithoutDebounce()
prop. Inteded to be used to set theloading
propMultiSelect
onChangeWithoutDebounce()
prop. Inteded to be used to set theloading
prop