Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] SideNav & ServiceNav: Remove forced uppercases #815

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

riitasointi
Copy link
Collaborator

Description

PR removes forced uppercase text from <ServiceNavigation> and <SideNavigation> components. This corresponds with the latest design changes.

Motivation and Context

Uppercase letters were thought difficult to read and depicted as "screaming"

Screenshots:

SideNavigation before:
image

SideNavigation after:
image


ServiceNavigation before:
image

ServiceNavigation after:
image

Release notes

SideNavigation

  • Breaking change: Remove forced uppercase text from level 1 <SideNavigationItem>

ServiceNavigation

  • Breaking change: Remove forced uppercase text from <ServiceNavigationItem>

@riitasointi riitasointi requested a review from LJKaski as a code owner December 15, 2023 13:34
Copy link
Collaborator

@LJKaski LJKaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riitasointi riitasointi force-pushed the feature/navs-without-uppercase branch from 0fc3262 to dc0e6ae Compare December 20, 2023 09:24
@riitasointi riitasointi merged commit 24ed70c into develop Dec 20, 2023
1 check passed
@riitasointi riitasointi deleted the feature/navs-without-uppercase branch December 20, 2023 09:34
@LJKaski LJKaski mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants