[Fix] Button support for icon only implementation #807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves support for Buttons with only an icon and no text content out of the box. Some changes:
aria-label
attributeicon
andiconRight
prop types changed fromReactNode
toReactElement
ActionMenuProps
changed from an interface to a type to accommodate changesMotivation and Context
This was requested by users and the redundant wrappers were noticed by the team.
How Has This Been Tested?
Tested by running locally on styleguidist and by trying out the new typing inside the project. Needs to be tested in another project to check the typing just in case.
Release notes
Button
Breaking change: Adjusted paddings to accommodate use with only icon and no content.
Breaking change: ButtonProps now require either
children
oraria-label
ActionMenu
Breaking change: Remove redundant custom styling via "icon only" class.