[Feature] Alert, InlineAlert and Notification style update #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
force-pushed
the
feature/alert-notification-colors
branch
from
c5ffadf to
2e27238
Compare
riitasointi
approved these changes
Nov 1, 2023
This was referenced Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the style of
Alert,InlineAlertandNotificationcomponents to match the updated design. In Notification, the internal structure was changed slightly to use an existingButtoncomponent variant instead of a custom button.Suomifi-design-tokensdependency was updated to version 6.0.0 to gain access to the new and changed colors.Motivation and Context
The designs were updated along with some recent color changes for better accessibility and usability. This simply applies the changes to the components.
How Has This Been Tested?
Visually checked against the designs in styleguidist on Chrome.
Release notes
Alert, InlineAlert
Notification
closeButtonPropsare now of typeButtonPropsGeneral
suomifi-design-tokensto 6.0.0