[Fix] ExpanderGroup conditional props #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riippi
requested review from
LJKaski,
riitasointi and
jenkrisu
as code owners
Riippi
force-pushed
the
fix/expandergroup-button-names
branch
2 times, most recently
from
2671176 to
415d22f
Compare
Riippi
force-pushed
the
fix/expandergroup-button-names
branch
from
415d22f to
c501a1b
Compare
riitasointi
approved these changes
Sep 26, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the props conditional so that
openAllTextandcloseAllTextbecome optional whenshowToggleAllButtonis set to false.Related Issue
https://jira.dvv.fi/browse/SFIDS-882
Motivation and Context
ExpanderGroup had
openAllTextandcloseAllTextas mandatory props even whenshowToggleAllButtonis set to false. This PR makes it more user friendly for developers.How Has This Been Tested?
Styleguidist
Release notes
ExpanderGroup
openAllTextandcloseAllTextare optional whenshowToggleAllButtonis set to false