Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Character counter for TextInput and Textarea #752

Merged
merged 17 commits into from
Jul 7, 2023
Merged

[Feature] Character counter for TextInput and Textarea #752

merged 17 commits into from
Jul 7, 2023

Conversation

LJKaski
Copy link
Collaborator

@LJKaski LJKaski commented Jul 5, 2023

Description

This PR adds character counter functionality to Textarea and TextInput components.

Motivation and Context

In some cases it is necessary to limit the input to text inputs and textarea components. In those cases it is important to let users know about the limit..

How Has This Been Tested?

Tested on:

  • Windows + NVDA +Chrome/Firefox/Edge
  • macOS + VoiceOver + Safari/Chrome
  • Android + TalkBack + Chrome
  • iOS + VoiceOver + Safari

Screenshots (if appropriate):

image

Release notes

TextInput, Textarea

  • Add character counter option and examples

@LJKaski LJKaski added the enhancement New feature or request label Jul 5, 2023
@LJKaski LJKaski self-assigned this Jul 5, 2023
@LJKaski LJKaski requested a review from riitasointi as a code owner July 5, 2023 12:34
@LJKaski LJKaski requested review from Riippi and jenkrisu as code owners July 5, 2023 12:34
@LJKaski LJKaski force-pushed the feature/character-counter branch from 8707a6f to 7082ad1 Compare July 6, 2023 09:57
jenkrisu
jenkrisu previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@jenkrisu jenkrisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@LJKaski LJKaski force-pushed the feature/character-counter branch from 7082ad1 to 8a0aa34 Compare July 6, 2023 12:45
@LJKaski LJKaski merged commit 1b00579 into develop Jul 7, 2023
@riitasointi riitasointi mentioned this pull request Jul 20, 2023
Merged
@riitasointi riitasointi mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkrisu jenkrisu jenkrisu approved these changes

@riitasointi riitasointi Awaiting requested review from riitasointi riitasointi is a code owner

@Riippi Riippi Awaiting requested review from Riippi

Assignees

@LJKaski LJKaski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LJKaski @jenkrisu @riitasointi