Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Dropdown screen reader problems #714

Merged
merged 2 commits into from
Apr 28, 2023
Merged

[Fix] Dropdown screen reader problems #714

merged 2 commits into from
Apr 28, 2023

Conversation

riitasointi
Copy link
Collaborator

@riitasointi riitasointi commented Apr 27, 2023 •
edited
Loading

Description

PR fixes issues regarding Dropdown usage with screen readers

  • Keyboard navigation is implemented by moving actual browser focus() to the list elements
  • When selecting an item, a small 10ms timeout is used before focusing back to the dropdown button. This hack seemed to be the only way to make NVDA + Firefox work properly

How Has This Been Tested?

Mac: Chrome and Safari with VoiceOver
iOS: Safari with VoiceOver
Windows: Chrome, Firefox, Edge with NVDA

Release notes

Dropdown

  • Fix screen reader problems

@riitasointi riitasointi added the bug Something isn't working label Apr 27, 2023
@riitasointi riitasointi self-assigned this Apr 27, 2023
Riippi
Riippi approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@Riippi Riippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riitasointi riitasointi merged commit cc5e0de into develop Apr 28, 2023
@riitasointi riitasointi deleted the fix/dropdown-screen-reader-problems branch April 28, 2023 07:05
@jenkrisu jenkrisu mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkrisu jenkrisu jenkrisu approved these changes

@Riippi Riippi Riippi approved these changes

@LJKaski LJKaski Awaiting requested review from LJKaski LJKaski is a code owner

Assignees

@riitasointi riitasointi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riitasointi @Riippi @jenkrisu