[Feature / Breaking change] Link list and link improvements #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
changed the title
jenkrisu
reviewed
Apr 17, 2023
jenkrisu
reviewed
Apr 18, 2023
jenkrisu
reviewed
Apr 18, 2023
jenkrisu
reviewed
Apr 18, 2023
jenkrisu
reviewed
Apr 18, 2023
jenkrisu
reviewed
Apr 18, 2023
jenkrisu
reviewed
Apr 18, 2023
LJKaski
force-pushed
the
feature/link-list
branch
from
33057df to
7963b83
Compare
jenkrisu
reviewed
Jun 12, 2023
jenkrisu
reviewed
Jun 12, 2023
jenkrisu
reviewed
Jun 12, 2023
LJKaski
force-pushed
the
feature/link-list
branch
from
f03e14b to
3d76551
Compare
riitasointi
reviewed
Jun 16, 2023
riitasointi
reviewed
Jun 16, 2023
riitasointi
approved these changes
Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
LinkListandLinkListItemcomponents to provide a uniform link list solution to the library. In addition, it adds smaller font size option as well as an "accent" variant to Link, ExternalLink and RouterLink components. RouterLink also now has the.fi-linkclass to bring it on the same realm with other link components in that regard.Motivation and Context
The new component was requested by multiple services. The need for smaller font size option and accented/bulleted option for links came up during the development.
How Has This Been Tested?
So far by running locally in styleguidist on chrome, firefox and edge.
Screenshots (if appropriate):
Release notes
General changes
LinkListandLinkListItemcomponentsRouterLink
.fi-linkclass to the component and use it for styling like in other link componentssmallScreenprop to allow smaller font size (16px) where needed.Link & ExternalLink
smallScreenprop to allow smaller font size (16px) where needed.variantprop