[Feature] DropdownItem disabled option #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkrisu
commented
Apr 14, 2023
| private handleKeyDown = (event: React.KeyboardEvent) => { | ||
| const { focusedDescendantId, showPopover } = this.state; | ||
| const popoverItems = Array.isArray(this.props.children) | ||
| ? this.props.children | ||
| : [this.props.children]; | ||
| : this.props.children !== undefined |
There was a problem hiding this comment.
Changed logic here, because previously it was possible to have popOverItems = [undefined] (truthy) and this never returned
jenkrisu
force-pushed
the
feature/dropdown-disabled-option
branch
from
f6a2ee2 to
621322a
Compare
riitasointi
approved these changes
Apr 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds disabled option to DropdownItem.
Motivation and Context
Dropdown had possibility to disable an option when it was implemented with Reach. Adding disabled prop makes functionality same as before.
How Has This Been Tested?
Windows (NVDA) Chrome, Edge, Firefox
iOS (VoiceOver) Safari, Chrome
Android, Chrome (BrowserStack)
Mac, Safari (BrowserStack)
Screenshots (if appropriate):
Release notes
(none)