[Feature] Expander facelift #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a visual update for the
<Expander>component. Biggest changes concern the open/close button, which is now implemented using flexbox instead of absolute positioning.Also removed this CSS line from ExpanderContent:
transform: scaleY(0). The same rule is already applied in thefi-expander_content-animanimation, and removing it from ExpanderContent's default state seemed to fix a Safari print bug described here: https://jira.dvv.fi/browse/SFIDS-673Motivation and Context
Expander's appearance was updated in Figma in order to better pop out from backgrounds and provide visual clues regarding click targets (hover styles)
How Has This Been Tested?
Styleguidist, Chrome, Safari
Screenshots:
Release notes
Expander & ExpanderGroup