Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Derived tokens from tokens library #690

Merged
merged 8 commits into from
Feb 3, 2023

Conversation

riitasointi
Copy link
Collaborator

@riitasointi riitasointi commented Jan 31, 2023

Description

This PR streamlines the library's design token implementation by importing all tokens from the suomifi-design-tokens npm package instead of having some of them coded in the ui-components repo.

This also means some breaking changes in naming. The following token categories have changed

  • radius --> radiuses
  • focus --> focuses

So now you would use them as thus suomifiDefaultTheme.focuses.absoluteFocus

suomifi-design-tokens version is now 5.0.0 which also means a slight change in blackBase color.

Motivation and Context

All tokens are now available in the suomifi-design-tokens package and it makes sense to use them from there.

How Has This Been Tested?

Styleguidist, CRA-app

Release notes

SuomifiTheme

  • Breaking change: Rename a couple of token categories
    • focus ---> focuses
    • radius ---> radiuses
  • Breaking change: update blackBase color from hsl(0, 0%, 16%) to hsl(0, 0%, 13%)
  • Refactor underlying implementation to use suomifi-design-tokens package for all tokens

@riitasointi riitasointi changed the title [Feature] Derived tokens from tokens library [Breaking change] Derived tokens from tokens library Jan 31, 2023
Copy link
Collaborator

@LJKaski LJKaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well. Well done :)

@riitasointi riitasointi merged commit a224e12 into develop Feb 3, 2023
@riitasointi riitasointi deleted the feature/derived-tokens-from-library branch February 3, 2023 10:11
@jenkrisu jenkrisu mentioned this pull request Feb 9, 2023
@jenkrisu jenkrisu mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants