[Feature] Loading state for SingleSelect & MultiSelect #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riippi
requested review from
LJKaski,
riitasointi and
jenkrisu
as code owners
Riippi
force-pushed
the
feature/multiselect-preloader
branch
from
60256c2 to
dd3316e
Compare
LJKaski
reviewed
Dec 30, 2022
jenkrisu
reviewed
Jan 17, 2023
jenkrisu
reviewed
Jan 17, 2023
jenkrisu
reviewed
Jan 17, 2023
src/core/Form/Select/BaseSelect/SelectEmptyItem/SelectEmptyItem.baseStyles.tsx
Show resolved
Hide resolved
jenkrisu
previously approved these changes
Jan 17, 2023
Riippi
force-pushed
the
feature/multiselect-preloader
branch
from
80d6eff to
95ae4cf
Compare
LJKaski
previously approved these changes
Jan 23, 2023
Co-authored-by: Jenni Unkuri <[email protected]>
Co-authored-by: Jenni Unkuri <[email protected]>
Riippi
force-pushed
the
feature/multiselect-preloader
branch
from
95ae4cf to
a1b13a1
Compare
jenkrisu
approved these changes
Jan 24, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for "loading state" in MultiSelect and SingleSelect.
Related Issue
https://jira.dvv.fi/browse/SFIDS-510
Motivation and Context
Provide a clear indication MultiSelect / SingleSelect is loading more data.
How Has This Been Tested?
MacOs Firefox, Chrome, Styleguidist, CRA
Screenshots (if appropriate):
Release notes
MultiSelect
SingleSelect