[Fix/BreakingChange] Multiselect onitemselect return type #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riitasointi
requested review from
LJKaski,
ketsappi and
Riippi
as code owners
jenkrisu
previously approved these changes
Nov 15, 2022
riitasointi
changed the title
riitasointi
force-pushed
the
fix/multiselect-onitemselect-return-type
branch
from
9a5da52 to
28de935
Compare
LJKaski
approved these changes
Jan 27, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
nullas a possible parameter in MultiSelect'sonItemSelect()prop. Null was there because the code had been copied over from SingleSelect whereonItemSelect()gets called also when the input is cleared. In MultiSelect there is no such behavior.Motivation and Context
This was reported as a bug by one of our users.
How Has This Been Tested?
Styleguidist
Release notes
MultiSelect
nullfrom possible parameters inonItemSelect()prop