[Feature] Remove font imports #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aappoalander
added
dependencies
LJKaski
reviewed
Aug 16, 2021
ketsappi
previously approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Tested with cra-TS project.
macOS + Brave
Already having the Source Sans Pro font on my pc, so couldn't see any change. Which is expected, of course.
iOS + Safari
As iOS do not have the font installed; by default it is using fallback fonts and after importing the font like in the provided example, the library fonts seems correct.
Seems to work great!
aappoalander
force-pushed
the
feature/remove-font-import
branch
from
8098949 to
20e45e1
Compare
ketsappi
approved these changes
Aug 17, 2021
LJKaski
approved these changes
Aug 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes internal font imports from global styles and adds documentation for adding the imports externally.
Motivation and Context
Font imports were included in the global styles for the library. The fonts were imported from google, which made it impossible to use self served fonts and created problems with CORS policies.
How Has This Been Tested?
Tested using styleguidist and Create React App Typescript project using Mac OS and Chrome.
Release notes
Fonts