Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ToggleInput example #487

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

aappoalander
Copy link
Contributor

Description

Fix for ToggleInput example. This PR combines two separate onClick handlers for a single ToggleInput component example.

Motivation and Context

Having more than one of the same event handlers in a React component is considered an error. This error had gone unnoticed due to md file formats not being checked by linters or build.

Release notes

ToggleInput

  • Fix example onClick handler.

@aappoalander aappoalander added the bug Something isn't working label Jun 30, 2021
@aappoalander aappoalander requested review from ketsappi and LJKaski June 30, 2021 11:41
@aappoalander aappoalander self-assigned this Jun 30, 2021
Copy link
Contributor

@ketsappi ketsappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in styleguidist to now work nicely. No more onClick prop told twice.

@aappoalander aappoalander merged commit 4849d7d into develop Jun 30, 2021
@aappoalander aappoalander mentioned this pull request Oct 4, 2021
@aappoalander aappoalander deleted the fix/toggle-input-expample branch October 13, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants