Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Icon color #480

Merged
merged 5 commits into from
Jun 28, 2021
Merged

[Feature] Icon color #480

merged 5 commits into from
Jun 28, 2021

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Jun 24, 2021 •
edited
Loading

Description

  • Add new baseColor prop for StaticIcon.
  • Update suomifi-icons to v4.0.0
  • Separate baseStyles to own file for StaticIcon.
  • Snapshots updated accordingly.

Motivation and Context

How Has This Been Tested?

Locally run the build and viewed inside styleguidist and DS-site.

Screenshots (if appropriate):

Icon without color changes and another with custom colors for highlightColor and baseColorProp.
trains

Release notes

  • Add new baseColor prop for StaticIcon.

ketsappi added 4 commits June 24, 2021 09:34
@ketsappi
Add fill and stroke colors for icons, for both highlight and base
ff7148b
@ketsappi
Update snapshots for icon changes
af1a396
@ketsappi
Add baseColor to StaticIcon's example
51f445e
@ketsappi
Update suomifi-icons to 4.0.0
29150ff 
This released version has the needed changes for the svg's that we can
change the highlight and base color for strokes and fills.
@ketsappi ketsappi added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 24, 2021
@ketsappi ketsappi requested review from aappoalander and LJKaski June 24, 2021 11:46
@ketsappi ketsappi marked this pull request as ready for review June 24, 2021 13:09
@aappoalander
Copy link
Contributor

Tested as part of vrk-kpa/suomifi-icons#55 and seems to be working as expected.

@ketsappi ketsappi merged commit 6205cd2 into develop Jun 28, 2021
@aappoalander aappoalander mentioned this pull request Jun 28, 2021
Merged
@ketsappi ketsappi deleted the feature/icon-color branch August 17, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aappoalander aappoalander aappoalander approved these changes

@LJKaski LJKaski Awaiting requested review from LJKaski LJKaski is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ketsappi @aappoalander