[Fix] VisuallyHidden to export props + move it to core #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aappoalander
approved these changes
Jun 16, 2021
|
Tested with Styleguidist build and Brave with VoiceOver and with TalkBack and Chrome. Seems to be working as expected / without changes to behaviour. Props export tested with DS-site and seems to be also working. |
LJKaski
approved these changes
Jun 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VisuallyHidden was not exporting props and therefore those were not available to library's users. This is now fixed.
Also moved VisuallyHidden from
componentstocorelevel.Motivation and Context
How Has This Been Tested?
Built locally and tested in in CRA-TS test project.
Release notes