[Feature] Soft disable support for Chip #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented in same logic as with the Button.
LJKaski
previously approved these changes
Jun 9, 2021
|
Looks good, but I would also add a styleguidist example. Use cases where a mandatory selection is indicated with a disabled chip should probably use this feature to work better with screen readers. |
aappoalander
approved these changes
Jun 10, 2021
|
Looks good and seems to be working with supported setup on MacOS and Android. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds soft disable support for a Chip. Implementation is mimicked from the Button, where the same functionality exists.
Motivation and Context
Soft disabled Chip was needed for currently in progress component, Combobox (MultiSelect). It enables screenreader users also to "see" selected but disabled Chips in the listing under the input.
How Has This Been Tested?
Locally in styleguidist.
Release notes