[Fix] Dropdown tab-key focus issue #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsappi
previously approved these changes
Jun 8, 2021
aappoalander
force-pushed
the
fix/dropdown-tab-keypress
branch
from
6fccd91 to
76c0201
Compare
LJKaski
approved these changes
Jun 8, 2021
ketsappi
approved these changes
Jun 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional logic for Dropdown tab-key event handling. Current version of Reach-UI has a focus issue with the used Listbox component that allows focus to default if tab key is pressed when the listbox menu is open. This PR introduces logic to prevent the focus from escaping.
Related Issue
reach/reach-ui#691
Motivation and Context
Current behaviour of Dropdown allowed focus to escape when using tab while the dropdown is open. Usually focus defaults to document body, which is really bad for keyboard, let alone screen reader, users. To temporarily address the issue:
How Has This Been Tested?
Tested with styleguidist build using MacOS Safari, Chrome and Edge.
Release notes