[Fix] Move Heading to core #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes component level implementation of the Heading component and moves all logic to core. It also addresses a documentation issue as well as an issue where as and asProp could both be given to the component and could potentially clash.
In addition, static variants were removed and replaced in tests and examples with using the variant prop.
Motivation and Context
Components level is no longer useful and is being removed from the library as a whole. Static variants are also being removed in general. The smaller issues were bugs that needed to be fixed in any case.
How Has This Been Tested?
Tested with automated tests as well as running locally in styleguidist in Chrome, Edge and Firefox.
Release notes
Heading