-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Button secondary noborder styles and button link variant #446
Merged
LJKaski
merged 12 commits into
develop
from
feature/button-secondary-noborder-and-link-variants
Mar 22, 2021
Merged
[Feature] Button secondary noborder styles and button link variant #446
LJKaski
merged 12 commits into
develop
from
feature/button-secondary-noborder-and-link-variants
Mar 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJKaski
added
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
labels
Mar 22, 2021
LJKaski
force-pushed
the
feature/button-secondary-noborder-and-link-variants
branch
from
March 22, 2021 09:15
af4fa11
to
0623e60
Compare
Looks solid and good to go! 💪 |
aappoalander
approved these changes
Mar 22, 2021
Merged
aappoalander
deleted the
feature/button-secondary-noborder-and-link-variants
branch
October 13, 2021 09:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the button tertiary variant with link variant. It also adjusts the button secondary noborder styles to work on different backgrounds. To make these changes, suomifi-design-tokens dependency was updated to get the recently updated color token values.
Motivation and Context
The implementation differed from the designs, and there were requests from the projects using the library to make button secondary noborder compatible with other background colors than white.
How Has This Been Tested?
Automated tests and running locally in Windows using Chrome, Firefox and Edge.
Screenshots (if appropriate):
secondary noborder hover styles with colored background
Release notes
Breaking changes:
Other changes: