Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Button secondary noborder styles and button link variant #446

Merged
merged 12 commits into from
Mar 22, 2021

Conversation

LJKaski
Copy link
Collaborator

@LJKaski LJKaski commented Mar 22, 2021

Description

This PR replaces the button tertiary variant with link variant. It also adjusts the button secondary noborder styles to work on different backgrounds. To make these changes, suomifi-design-tokens dependency was updated to get the recently updated color token values.

Motivation and Context

The implementation differed from the designs, and there were requests from the projects using the library to make button secondary noborder compatible with other background colors than white.

How Has This Been Tested?

Automated tests and running locally in Windows using Chrome, Firefox and Edge.

Screenshots (if appropriate):

secondary noborder hover styles with colored background
image

Release notes

Breaking changes:

  • Button tertiary variant replaced by link button variant
  • Button secondary-noborder variant renamed to secondaryNoBorder
  • depthSecondaryDark1 color token value changed

Other changes:

  • suomifi-design-tokens dependency updated to latest available
  • Button secondaryNoBorder variant hover styles changed

@LJKaski LJKaski added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 22, 2021
@LJKaski LJKaski self-assigned this Mar 22, 2021
@LJKaski LJKaski force-pushed the feature/button-secondary-noborder-and-link-variants branch from af4fa11 to 0623e60 Compare March 22, 2021 09:15
@LJKaski LJKaski requested a review from aappoalander March 22, 2021 11:43
@aappoalander
Copy link
Contributor

Looks solid and good to go! 💪

@LJKaski LJKaski merged commit 1f589a0 into develop Mar 22, 2021
@aappoalander aappoalander mentioned this pull request Jun 28, 2021
@aappoalander aappoalander deleted the feature/button-secondary-noborder-and-link-variants branch October 13, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants