-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Move toggle to core #434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aappoalander
added
enhancement
New feature or request
DX
Refactoring for maintainability
labels
Feb 2, 2021
aappoalander
force-pushed
the
feature/move-toggle-to-core
branch
from
February 5, 2021 08:14
40120b2
to
67b1519
Compare
ketsappi
reviewed
Feb 5, 2021
ketsappi
reviewed
Feb 5, 2021
ketsappi
reviewed
Feb 5, 2021
ketsappi
reviewed
Feb 9, 2021
ketsappi
previously approved these changes
Feb 9, 2021
aappoalander
force-pushed
the
feature/move-toggle-to-core
branch
from
February 9, 2021 07:08
d593668
to
7627e96
Compare
ketsappi
approved these changes
Feb 9, 2021
LJKaski
approved these changes
Feb 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes Toggle components level implementation and introduces various improvements and changes to the component:
Motivation and Context
Toggle button had unstyled version which was not working properly and added unnecessary maintenance burden. In addition, use of uuid prevented SSR from working properly. Also, the use cases for these components, as well as the APIs are somewhat different, so having button and input as variants of the same component makes no sense.
How Has This Been Tested?
Tested with Mac OS VoiceOver and NVDA + Windows using Chrome, Firefox, Safari and Edge. Tested using a CRA test project, styleguidist and SSR test project.
Release notes
Toggle