[Feature] SearchInput auto id #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aappoalander
added
enhancement
aappoalander
force-pushed
the
feature/searchinput-auto-id
branch
from
6050c40 to
d413b8c
Compare
aappoalander
force-pushed
the
feature/searchinput-auto-id
branch
from
d413b8c to
6378a16
Compare
ketsappi
approved these changes
Feb 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds AutoId for SearchInput and replaces the old uuid implementation. By doing so SSR support is improved and the id mismatch between server and client no longer happens.
In addition, this PR introduces an intermediate style wrapper so that it is now possible to add margin/display etc styles directly to SearchInput without breaking the component.
Motivation and Context
SSR Should be fully supported to allow faster page loads and hydration on client side. Positioning the components should be possible without the danger of breaking the internal layout and styles and this can be achieved by adding an additional style wrapper inside the component.
How Has This Been Tested?
Tested with Mac OS and VoiceOver using Firefox, Safari and Chrome and with Win10 and NVDA using Chrome, Firefox and Edge.
Release notes
SearchInput