Feature/expander title checkbox #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsappi
reviewed
Dec 11, 2020
ketsappi
reviewed
Dec 11, 2020
src/core/Expander/ExpanderTitleButton/ExpanderTitleButton.test.tsx
Outdated
Show resolved
Hide resolved
ketsappi
reviewed
Dec 11, 2020
ketsappi
reviewed
Dec 11, 2020
ketsappi
reviewed
Dec 11, 2020
ketsappi
previously approved these changes
Dec 14, 2020
ketsappi
reviewed
Dec 16, 2020
|
Looking good. |
LJKaski
approved these changes
Dec 16, 2020
ketsappi
approved these changes
Dec 16, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces ExpanderTitle as a variant for ExpanderTitleButton. ExpanderTitle only has open / close button on the far right of the title to support focusable content on the remaining title area. This makes it possible to use the expander with common use cases like checkbox in the expander title.
In addition, most of the Expander related tests are rearranged or refactored so that each component now have separate test files.
Motivation and Context
There was a clear need to support focusable content on the expander title and the variant with whole title are as button did not work with these use cases.
How Has This Been Tested?
Tested with Styleguidist, CRA TypeScript, SSR application by using VoiceOver with Chrome, Firefox and Safari and by using NVDA with Chrome, Firefox, Edge and IE.
Screenshots (if appropriate):
Release notes